[Webkit-unassigned] [Bug 136386] Update webkit dashboard to support performance bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136386





--- Comment #12 from Dana Burkart <dburkart at apple.com>  2014-09-02 18:11:38 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:253
> > > +            if (!testStep.results || !testStep.results[0]) {
> > 
> > Should this be
> > 
> > if (!testStep.results || testStep.results[0] === BuildbotIteration.SUCCESS)
> > 
> > ?
> > 
> 
> No, we're actually testing for failure of any kind, not success (failure is non-zero).
> 

Actually, I misread the context. I am testing for success, however I was following the same convention used earlier in the file. I can change it in both places if you want.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.