[Webkit-unassigned] [Bug 138225] bisect-builds should support WebKit clients other than Safari

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138225

--- Comment #4 from Matthew Hanson <matthew_hanson at apple.com> ---
Comment on attachment 240693
  --> https://bugs.webkit.org/attachment.cgi?id=240693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240693&action=review

Thanks for the review!

>> Tools/Scripts/bisect-builds:38
>> +# $applicationPath = "/path/to/Application.app";
> 
> This should not change unless we're going to support $Settings::applicationPath and remove $Settings::safariPath.  Or keep $safariPath and add $applicationPath here.
> 
>   # $safariPath = "/path/to/Safari.app";
> + # $applicationPath = "/path/to/Application.app";

I noticed this after sending out this patch. I'll keep it set to $safariPath here. This might be a good thing to change/add in a future patch.

>> Tools/Scripts/bisect-builds:73
>> +my $applicationPath;
> 
> I would expect this to be change to the following if we were supported in the ~/.bisect-buildsrc file:
> 
> my $applicationPath = $Settings:: applicationPath;

See above.

>> Tools/Scripts/bisect-builds:436
>> +    push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $isBundle;
> 
> Very nice.  Should we only do this if $safariPath is set instead of $isBundle?
> 
>     push @args, "--args", "-ApplePersistenceIgnoreState", "YES" if $safariPath;
> 
> Or does this work for multiple apps?

This works with multiple apps. I have tested it with Mail and iTunes so far, but I would expect it to work with others.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141031/5ce59a97/attachment-0002.html>