[Webkit-unassigned] [Bug 138127] Insecure content warnings not emitted when page is restored from page cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138127

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at gnome.org

--- Comment #5 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Thanks for the review. I'll work on cross-platform tests before I try to address your comments.

(In reply to comment #4)
> This is basically a new feature, and I think it'd be important to test cross
> platform.

I'd call it a minor security bug rather than a feature, since it's unsafe for a port to use these events unless it completely blocks all mixed content.

> > Source/WebCore/history/CachedFrame.cpp:107
> > +    if (frame.didDisplayInsecureContent()) {
> 
> How is it okay to check this on the frame when (in the common main-frame
> case) it is being reused from the previously shown content?

You're right; now loading a single page with insecure content causes unrelated future loads from the page cache to emit these events, like you suspected. That's very bad. I'll add a test for this.

> Did you run the WK2 API tests before making this change?  I suspect they
> will be very relevant.

If we're thinking of the same tests (the Google framework ones), those all passed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/3c56022a/attachment-0002.html>