[Webkit-unassigned] [Bug 138229] New: Remove wetness from PatchAnalysisTask, in particular the calls to _build_and_test_without_patch() and the logic that follows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138229

            Bug ID: 138229
           Summary: Remove wetness from PatchAnalysisTask, in particular
                    the calls to _build_and_test_without_patch() and the
                    logic that follows
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jake.nielsen.webkit at gmail.com

Both inside and after this line:
if self._results_failed_different_tests(first_results, second_results):

there is fairly similar logic to determine whether the failing tests are present without the patch applied. They should be condensed into one code path somehow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/59e46858/attachment-0002.html>