[Webkit-unassigned] [Bug 138220] Implement action menus for text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138220

--- Comment #5 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #3)
> Comment on attachment 240685 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240685&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:118
> > +    if (!hitTestResult->isSelected())
> 
> Shouldn't this be "if we have no selection at all"? I'm not sure.
> 
I did consider this, but I don't think so…I think it feels a lot more natural if invoking the action menu on text moves the selection there since it normally creates a selection. We can look at this in person if you like.

> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:314
> > +    if (!hitTestResult->isTextNode())
> > +        return @[ ];
> 
> No need to check this here, the caller already checked. At most, ASSERT.
> Also, our _type system depends on these things actually returning the menu
> we ask for!
> 

Okay!

> > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:324
> > +    _page->executeEditCommand(String("copy"));
> 
> Doesn't the literal->String conversion happen magically?
> 

Oh, yes! Fixed.

> > Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:532
> > +PassRefPtr<Range> WebPage::rangeForDictionaryLookupAtHitTestResult(const WebCore::HitTestResult& hitTestResult, NSDictionary **options)
> 
> NSDictionary ** could be 'NSDictionary*& options' instead, I think?

I don't think so? WebKitSystemInterface function wants a **, and I can't seem to make it work with a *& passed into the WebPage functions, but I'm falling down the pointer/reference rabbit hole a little bit, so yeah.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/392f0554/attachment-0002.html>