[Webkit-unassigned] [Bug 138220] Implement action menus for text
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 30 12:26:10 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=138220
Tim Horton <thorton at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #240685|review? |review+
Flags| |
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 240685
--> https://bugs.webkit.org/attachment.cgi?id=240685
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=240685&action=review
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:118
> + if (!hitTestResult->isSelected())
Shouldn't this be "if we have no selection at all"? I'm not sure.
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:314
> + if (!hitTestResult->isTextNode())
> + return @[ ];
No need to check this here, the caller already checked. At most, ASSERT. Also, our _type system depends on these things actually returning the menu we ask for!
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:324
> + _page->executeEditCommand(String("copy"));
Doesn't the literal->String conversion happen magically?
> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:532
> +PassRefPtr<Range> WebPage::rangeForDictionaryLookupAtHitTestResult(const WebCore::HitTestResult& hitTestResult, NSDictionary **options)
NSDictionary ** could be 'NSDictionary*& options' instead, I think?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/91f14250/attachment-0002.html>
More information about the webkit-unassigned
mailing list