[Webkit-unassigned] [Bug 137634] [EFL] Fix popup non-occurrence condition.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137634

--- Comment #7 from KwangHyuk <hyuki.kim at samsung.com> ---
(In reply to comment #6)
> Comment on attachment 239677 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=239677&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebPopupMenu.cpp:126
> > +#if PLATFORM(EFL)
> 
> I think we can move this to WebPopupMenuEfl.cpp instead.

I have checked it and reach any conclusion.

This doesn't look possible without modifying WebPopupMenu since WebPopupMenu is created using static create api and its own constructor is private member.

So, I am checking whether it's ok if I modify this ?

void RenderMenuList::hidePopup()
{
#if !PLATFORM(IOS)
    if (m_popup)
        m_popup->hide();

    // call popupDidHide() in here ? 
#endif
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141030/bfcb7944/attachment-0002.html>