[Webkit-unassigned] [Bug 138193] bisect-builds should filter out nightlies that predate the introduction of an OS X operating system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138193

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240636|review?                     |review+
              Flags|                            |

--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 240636
  --> https://bugs.webkit.org/attachment.cgi?id=240636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240636&action=review

r=me with the comments resolved.

> Tools/ChangeLog:10
> +        It also does a bit of refactoring, including distinguishing between versions and version strings and
> +        saving versions to local variables instead of using eval in each conditional.

+1 for the performance optimization.  :)

> Tools/ChangeLog:18
> +        Restrict the set of nifhtlies to r122421 and above when running Mountain Lion.

Typo:  nifhtlies => nightlies

> Tools/Scripts/bisect-builds:349
> +    }
> +
> +    if ($osxVersion ge v10.5) {

Should this turn into an elsif?  There's no need to re-run the code in this block for 10.8, 10.9 or 10.10.

    } elsif ($osxVersion ge v10.5) {

If we wanted to be thorough, we could also add a FIXME comment for v10.6 and v10.7, but it probably doesn't matter at this point.

> Tools/Scripts/bisect-builds:364
>          if ($safariVersion eq "4 Public Beta") {

This line needs to change to:

        if ($safariVersionString eq "4 Public Beta") {

> Tools/Scripts/bisect-builds:375
>              die "Requires Safari 2.0 or newer";

You could change the die statement below this patch context to be:

        die "Requires Mac OS X 10.4 (Tiger) or later";

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141029/68c20153/attachment-0002.html>