[Webkit-unassigned] [Bug 138178] Implement action menus for data detected items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138178

WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org

--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org> ---
Attachment 240611 did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:63:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: WebKitLibraries/WebKitSystemInterface.h:132:  The parameter name "controlSize" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: WebKitLibraries/WebKitSystemInterface.h:134:  The parameter name "actionContext" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/mac/ActionMenuHitTestResult.mm:84:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141029/e97cce0d/attachment-0002.html>