[Webkit-unassigned] [Bug 137299] POST form data is missing with a custom NSURLProtocol

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137299

--- Comment #21 from Daniel <danielo at opera.com> ---
> ResourceRequestWithBody {
> I don’t understand the purpose of this class
> I understand the desire to have clarity about whether a body is present, but this does not seem to be the right way to accomplish that.

That's correct. It's only to trigger a different serialization method to work (pick a different ArgumentCoder<T>). The current IPC is implemented by using templates. When you call a send() method, it uses some magic (variadic templates) to determine an ArgumentCoder by type of the passed argument (for each argument). It's done at compile time.

Another option to fix it would be to pass the message type (class MT) through this template code path. I could add a parameter MT that you pass to send(), so that it uses a different coder method in the end if the MT matches "StartLoading" type.

Another option to fix it would be to add a flag to ResourceRequest. This sounds dirty to me, because this flag conceptually doesn't belong to ResourceRequest. It belongs to a party which is managing serialization.

Another option would be to avoid using templates at all, and just inline them in a place where send() is called, so that all argument encoding parameters are fixed there, i.e. create a message to pass by hand instead of letting the template magic do it automatically. This is dirty as well.

What do you think is best?
Do you have other ideas?

> I don’t think the approach is quite right here. Also, the patch does not build on any of the EWS bots, so review-.

I'm looking at the errors ( https://webkit-queues.appspot.com/patch/240538 ), but I don't understand them. It looks like #import statements are missing, but it's not true. I'm building using Xcode and command line (build-webkit script), and it builds well, but I'm only building in debug mode. It's some release configuration problem. I'll try to build a release and see what's wrong. If you know what's wrong, please let me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141029/f8f894a4/attachment-0002.html>