[Webkit-unassigned] [Bug 137302] location.href is not updated on a redirect with a custom protocol

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 27 06:17:26 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137302

--- Comment #10 from Daniel <danielo at opera.com> ---
> You can only use this excuse for tests when you believe there is no observable difference after your change.
> In this case, we would crash in Debug due to the assertion so it is observable and should have a test.

I couldn't find a place in code where I could put a simple unit test for CredentialStorage::findDefaultProtectionSpaceForURL, so I've just changed the log message.

The rest remarks are fixed.

> Weird number of spaces at line-start
What does it mean?
I did Xcode style indentation there that you've asked there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141027/24c954f3/attachment-0002.html>


More information about the webkit-unassigned mailing list