[Webkit-unassigned] [Bug 138063] _actionMenuItemsForHitTestResult should also take a type indicating what the menu was built for

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138063

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240446|review?                     |review+
              Flags|                            |

--- Comment #3 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 240446
  --> https://bugs.webkit.org/attachment.cgi?id=240446
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=240446&action=review

> Source/WebKit2/Shared/API/c/WKActionMenuTypes.h:40
> +typedef uint32_t WKActionMenuType;

Can you give this an underscore prefix in case we ever want to use this name for something in the modern API?

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:68
> +

Extra newline.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141024/634e7632/attachment-0002.html>