[Webkit-unassigned] [Bug 30322] WebKit level persistent caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30322

--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 240390
  --> https://bugs.webkit.org/attachment.cgi?id=240390
yet another

View in context: https://bugs.webkit.org/attachment.cgi?id=240390&action=review

> Source/WebCore/testing/Internals.cpp:393
> +        return "Null xhr";

Shouldn't we use ASCIILiteral() for these?

> Source/WebKit2/NetworkProcess/NetworkCache.cpp:213
> +        partition = WTF::ASCIILiteral("No Partition");

We probably don't need the WTF::

> Source/WebKit2/NetworkProcess/NetworkCache.cpp:264
> +    default:

I find it weird default is first :)

> Source/WebKit2/NetworkProcess/NetworkCache.cpp:310
> +    RefPtr<WebCore::SharedBuffer> buffer = nullptr;

We don't need the = nullptr;

> Source/WebKit2/NetworkProcess/NetworkCache.h:52
> +    NetworkCache();

Does this need to be public?

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:515
> +    (std::unique_ptr<NetworkCache::Entry> entry)

We are not passing ownership, why is this a unique_ptr and not a reference?

> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:526
> +            if (entry && entry->buffer)

Why the entry null check here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141024/106971f0/attachment-0002.html>