[Webkit-unassigned] [Bug 130967] erroneous date calculations on march 30, 2014 (CET/CEST time zone) the day on which daylight savings time changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130967

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240259|                            |review+
              Flags|                            |

--- Comment #56 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 240259
  --> https://bugs.webkit.org/attachment.cgi?id=240259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240259&action=review

> Source/JavaScriptCore/runtime/JSDateMath.cpp:200
>      double result = (day * WTF::msPerDay) + ms;
>  
> -    if (!inputIsUTC)
> -        result -= localTimeOffset(vm, result).offset;
> +    if (inputTimeType == WTF::LocalTime)
> +        result -= localTimeOffset(vm, result, inputTimeType).offset; // result is in local time milliseconds.

Previously, you said that "The result value can be local time and UTC time according to InputTimeType.”  To clarify, what do you mean when in this added comment when you said that the "result is in local time milliseconds”?  Did you mean that the previous result was in local time, and that you’re converting it to UTC time now?  Or did you mean the previous result is in UTC time and you’re converting it to local time?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141022/1d350216/attachment-0002.html>