[Webkit-unassigned] [Bug 130967] erroneous date calculations on march 30, 2014 (CET/CEST time zone) the day on which daylight savings time changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 22 04:38:11 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=130967

--- Comment #55 from Byungseon Shin <sun.shin at lge.com> ---
@Mark, thanks for the review.

I have applied all of requests from you except following:
=========================================================================
> Source/JavaScriptCore/runtime/JSDateMath.cpp:197
>      double result = (day * WTF::msPerDay) + ms;

Rather than adding the comment below, I suggest renaming “result” to “localTimeResult”.  I think the code will be clearer that way.


The result value can be local time and UTC time according to InputTimeType. 
So, I think it would be better to keep use the value name of result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141022/55e6b588/attachment-0002.html>


More information about the webkit-unassigned mailing list