[Webkit-unassigned] [Bug 137775] [GTK] Minibrowser : Add window fullscreen support for Minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137775

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 239941
  --> https://bugs.webkit.org/attachment.cgi?id=239941
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239941&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:575
> +    if (!window->fullScreenIsEnabled) {
> +        gtk_window_fullscreen(GTK_WINDOW(window));
> +        gtk_widget_hide(window->toolbar);
> +        window->fullScreenIsEnabled = TRUE;
> +    } else {
> +        gtk_window_unfullscreen(GTK_WINDOW(window));
> +        gtk_widget_show(window->toolbar);
> +        window->fullScreenIsEnabled = FALSE;
> +    }

We already have code to enter/leave fullscreen when requested by wk, maybe we can reuse that code to make it work also when requested by the user, because there are some inconsistencies. The other code shows a message explaining the user how to leave fullscreen mode, and the keybindings are f or ESC, not F11. Also the other code takes care of showing/hide the findbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141022/21ccf81a/attachment-0002.html>