[Webkit-unassigned] [Bug 137918] Use references instead of pointers in EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137918

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 240197
  --> https://bugs.webkit.org/attachment.cgi?id=240197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240197&action=review

Looks good.

> Source/WebCore/editing/EditingStyle.cpp:648
>  template<typename T>
>  TriState EditingStyle::triStateOfStyle(T* styleToCompare, ShouldIgnoreTextOnlyProperties shouldIgnoreTextOnlyProperties) const

Seems like T* needs to change to T& here too, in a subsequent patch.

> Source/WebCore/editing/EditingStyle.cpp:851
> +    return getPropertiesNotIn(*m_mutableStyle.get(), computedStyle)->isEmpty();

No need for ".get()" here or in the many other places that do *x.get().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/2cccca1d/attachment-0002.html>