[Webkit-unassigned] [Bug 136938] XMLHttpRequest should have a responseURL attribute (added in recent XHR specification drafts)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136938

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240188|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #38 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 240188
  --> https://bugs.webkit.org/attachment.cgi?id=240188
Patch-Updated-Review7

View in context: https://bugs.webkit.org/attachment.cgi?id=240188&action=review

Looked over the tests, which look good. Please just get rid of the const_cast.

> Source/WebCore/xml/XMLHttpRequest.cpp:340
> +    const_cast<URL&>(m_response.url()).removeFragmentIdentifier();

This modifies a URL inside m_response, which is definitely a wrong thing to do here (as the constness implies). You need to make a temporary copy, and remove the fragment from it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/934eb0c2/attachment-0002.html>