[Webkit-unassigned] [Bug 136981] ArgumentEncoder::encode does not support long long

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136981

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240204|review?                     |review+
              Flags|                            |

--- Comment #16 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 240204
  --> https://bugs.webkit.org/attachment.cgi?id=240204
Cast std::chrono::duration.count() to int64_t in ArgumentCoder

View in context: https://bugs.webkit.org/attachment.cgi?id=240204&action=review

> Source/WebKit2/Platform/IPC/ArgumentCoders.h:110
> +        static_assert(std::is_integral<Rep>::value && std::is_signed<Rep>::value && sizeof(Rep) <= sizeof(int64_t), "Rep should be an integer which can be fit in an int64_t.");

I would phrase this differently: "Serialization of this Rep type is not supported yet." With the current phrasing, someone hitting this error will not know whether it's verifying that we never try to encode something else (for some unstated subtle reason), or if it's only documenting a current limitation.

Alternatively, we could only specialize the template for supported types.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/73869389/attachment-0002.html>