[Webkit-unassigned] [Bug 137906] Don't create cached functions for HTMLDocument.write*()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137906

--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
(In reply to comment #2)
> Comment on attachment 240172 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240172&action=review
> 
> > Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:69
> > +    if (equal(propertyName.publicName(), "write")) {
> 
> Given that this idiom is a good one, I think we should add:
> 
>     bool operator==(PropertyName, const char*);
> 
> So we don't have to write this longer sequence at each call site. I also
> think it’s possibly slightly more efficient to save one branch and use uid()
> instead of publicName() since the empty uniques would never compare equal to
> a non-empty string. But that's the kind of thing that I would like the
> person writing the override to worry about rather than having to worry about
> it at each call site.

Thanks for the review.

I'll make the suggested changes, including using uid() in another patch.  Tracked in <https://bugs.webkit.org/show_bug.cgi?id=137925> - "Add operator==(PropertyName, char*)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/76b85148/attachment-0002.html>