[Webkit-unassigned] [Bug 137631] DOMTimer nesting level may not impact each other.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137631

--- Comment #9 from Horky <chenhao at ucweb.com> ---
(In reply to comment #7)
> Comment on attachment 240098 [details]
> Fixing patch for review
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240098&action=review
> 
> Looks good. A few small issues.
> 
> A larger issues is that we require a regression test with every bug fix. Can
> we construct one that demonstrates this bug? If we cannot, then the change
> log should include information about why we were not able to construct a
> regression test.
> 
> > Source/WebCore/ChangeLog:6
> > +        Unreviewed.
> 
> This needs to include the Reviewed by NOBODY (OOPS!) line so the patch
> management system can add the name of the reviewer here.
> 
> > Source/WebCore/ChangeLog:9
> > +        (WebCore::DOMTimer::fired):
> 
> This needs to describe the change and explain why it’s correct.
> 
> > Source/WebCore/page/DOMTimer.cpp:211
> > +
> 
> I suggest omitting this blank line.

Thanks! I updated it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/c1b07815/attachment-0002.html>