[Webkit-unassigned] [Bug 137860] Add relList to the anchor, area and link elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137860

--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 240155
  --> https://bugs.webkit.org/attachment.cgi?id=240155
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240155&action=review

Patch looks fine, but for some reason tests are failing on the bots. So I am not setting commit-queue+ on this until we find out what’s wrong. I guess Benjamin said he would land this by hand.

> Source/WebCore/html/HTMLAnchorElement.cpp:267
> +        if (SpaceSplitString::spaceSplitStringContainsValue(value, "noreferrer", true))
> +            m_linkRelations |= RelationNoReferrer;

Now that you have moved this here, I spotted a mistake in it. Something about having it right here in parseAttribute makes it clear to me: This sets RelationNoReferrer, but never clears it if the rel attribute is changed back to a value that does not include "noreferrer". We should return to this code later and fix this bug, even though it’s not new.

> Source/WebCore/html/RelList.cpp:36
> +    m_relAttributeValue.set(element.fastGetAttribute(HTMLNames::relAttr), false);

Maybe SpaceSplitString has a constructor we could use instead of calling set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141021/a30c590d/attachment-0002.html>