[Webkit-unassigned] [Bug 137897] New: Use glFinish instead of glFlush when drawing final GL output to screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137897

            Bug ID: 137897
           Summary: Use glFinish instead of glFlush when drawing final GL
                    output to screen
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: roger_fong at apple.com

When we want to draw the final WebGL output to the screen we call drawInCGLContext which in turn calls GraphicsContext3D::prepareTexture.
We used to call glFinish here, which pushes all buffered gl operations and blocks until every operation has been completed and every last pixel has been drawn.

glFlush also pushes all buffered gl operations but returns immediately.

Using glFinish is a huge performance hit and based on my testing does not seem to offer any particular benefit over glFlush.
Thus we will switch to using glFlush.

This gives us a 20% performance boost on Unity 3d tests and a 33% boost on the frame rate on http://threejs.org/examples/#webgl_performance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/37f49beb/attachment-0002.html>