[Webkit-unassigned] [Bug 137891] Add action menu support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137891

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240143|review?                     |review+
              Flags|                            |

--- Comment #5 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 240143
  --> https://bugs.webkit.org/attachment.cgi?id=240143
Patch with slightly different WK2 spin

View in context: https://bugs.webkit.org/attachment.cgi?id=240143&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3710
> +    NSMutableArray *menuItems = [NSMutableArray array];
> +
> +    if (!hitTestResult)
> +        return menuItems;
> +
> +    if (!hitTestResult->absoluteLinkURL().isEmpty())
> +        return [self _defaultMenuItemsForLink];

I'd write this as 

if (WebHitTestResult* hitTestResult = _data->_page->activeActionMenuHitTestResult()) {
    if (!hitTestResult->absoluteLinkURL().isEmpty())
        return [self _defaultMenuItemsForLink];
}

return @[]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/7bcb2bca/attachment-0002.html>