[Webkit-unassigned] [Bug 137876] Avoid unnecessary NSURLResponse construction for QuickLook on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137876

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 240109
  --> https://bugs.webkit.org/attachment.cgi?id=240109
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240109&action=review

> Source/WebCore/platform/network/ios/QuickLook.mm:501
> +    std::unique_ptr<QuickLookHandle> quickLookHandle(new QuickLookHandle([loader.originalRequest().nsURLRequest(DoNotUpdateHTTPBody) URL], nil, response.nsURLResponse(), delegate.get()));

The correct style here is to use std::make_unique, not new. But I imagine if we tried that we’d have to change what’s public.

> Source/WebCore/platform/network/ios/QuickLook.mm:504
>      return WTF::move(quickLookHandle);

Normally we don’t need WTF::move for a return value in a case like this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/4983ef58/attachment-0002.html>