[Webkit-unassigned] [Bug 137803] [GTK] Several labels are white instead of black

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137803

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org

--- Comment #6 from Martin Robinson <mrobinson at webkit.org> ---
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 240126 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=240126&action=review
> > 
> > > Source/WebCore/ChangeLog:10
> > > +        Recent GTK+ versions require to explicitly set the state before
> > > +        getting a color.
> > > +
> > 
> > The changelog does not mention at all the change regarding
> > gtk_style_context_get_background_color vs. gtk_style_context_get_color. It
> > might be best to write a brief note about that here. What necessitated it?
> 
> There's actually no change, I mean, *BakcgroundColor functions called
> gtk_style_context_get_background color and the *ForegroundColor function
> called gtk_style_context_get_color. That hasn't changed, I added a enum
> paramater to call one or the other to avoid adding to functions.


Sorry. I misunderstood the change. Might be worth mentioning the refactor though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/354c8b41/attachment-0002.html>