[Webkit-unassigned] [Bug 137803] [GTK] Several labels are white instead of black

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137803

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240126|review?                     |review+
              Flags|                            |

--- Comment #4 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 240126
  --> https://bugs.webkit.org/attachment.cgi?id=240126
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240126&action=review

> Source/WebCore/ChangeLog:10
> +        Recent GTK+ versions require to explicitly set the state before
> +        getting a color.
> +

The changelog does not mention at all the change regarding gtk_style_context_get_background_color vs. gtk_style_context_get_color. It might be best to write a brief note about that here. What necessitated it?

> Source/WebCore/rendering/RenderThemeGtk.cpp:1343
> +    // Recent GTK+ versions require to explicitly set the state before getting the color,
> +    gtk_style_context_set_state(context, state);
> +

Probably best to say what version introduced this change, if possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/2e3e5ee5/attachment-0002.html>