[Webkit-unassigned] [Bug 137862] [GTK] Add WebKitWebResource::failed-with-tls-errors signal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 20 08:07:39 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137862

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 240084 [details]
> Patch
> 
> For compatibility's sake, it sounds like we should also emit the failed
> signal, or do you think that is not necessary?

This is different to the WebView signal. In the WebView signal you are supposed to be able to react to the signal, or ignore it. That's why it's boolean, you can handle it (to show the block page or whatever) or not, and if not handled, the default behaviour is to emit the failed signal, so that the normal failed handler will show the error page. In the case of resources, we don't have a default handler for load failures, the signal is only informative, you are not supposed to handle it or not. The GError passed to failed signal doesn't provide any additional information, you already know it's a TLS failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/d45103f0/attachment-0002.html>


More information about the webkit-unassigned mailing list