[Webkit-unassigned] [Bug 137553] abandoned select option is reselected when shift selecting new options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137553

--- Comment #21 from Pascal Jacquemart <p.jacquemart at samsung.com> ---
Comment on attachment 239977
  --> https://bugs.webkit.org/attachment.cgi?id=239977
After review

View in context: https://bugs.webkit.org/attachment.cgi?id=239977&action=review

>> LayoutTests/fast/forms/listbox-selection-after-typeahead-expected.txt:10
>> +PASS selectionPattern() is "0000010"
> 
> It's not obvious to me why selecting "M" would result in 5th element being selected.
> Why don't we rename the value so that we can call keyDownOnSelect("5")?

Even by renaming the options, it won't be obvious unless you open the test itself

>> LayoutTests/fast/forms/listbox-selection-after-typeahead.html:10
>> +    }
> 
> What's the point of this style? Is this required?
> Can't we specify in the inline style attribute?

This style removing border, margin and padding is used to simplify the mouse coordinates computation to click on a specific option
In-lining the style, sure.

>> LayoutTests/fast/forms/listbox-selection-after-typeahead.html:35
>> +function keyDownOnSelect(identifier, modifier) {
> 
> Again, I don't think keyDownOnSelect is a descriptive name for this function.
> How about sendKeyDownAfterFocusingSelect?
> But do we really need to focus select element each time?
> It seems like the focus should be on the select element after the first test case.

It was for debugging purpose, I think few other tests apply the same strategy
I understand it sound redundant. This was to cope with the debugger taking the focus while debugging
As you expected it is working without calling select.focus() now

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/aa6deab9/attachment-0002.html>