[Webkit-unassigned] [Bug 137812] [GTK] Add initial gestures support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137812

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #11)
> Comment on attachment 240023 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240023&action=review
> 
> Let's give it a try! The only thing we need to address before landing is the
> misunderstanding related to the factory method and the constructor.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:894
> > +        priv->gestureController = GestureController::create(*priv->pageProxy);
> 
> We should call the constructor here:
> 
> priv->gestureController =
> std::make_unique<GestureController>(*priv->pageProxy);
> 
> See comment below for the rationale.
> 
> > Source/WebKit2/UIProcess/gtk/GestureController.cpp:52
> > +
> 
> Sorry if I didn't explain myself correctly, but this is not what I was
> asking about. This indeed looks very weird (a public factory and a public
> constructor). What I think we should do is to make the constructor public
> and use make_unique<> in the callers. That's something Anders is actively
> pushing for new code, see: https://bugs.webkit.org/show_bug.cgi?id=137765#c13

Ok, understood.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/6458b8bb/attachment-0002.html>