[Webkit-unassigned] [Bug 137860] Add relList to the anchor, area and link elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 19 20:19:18 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137860

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 240082
  --> https://bugs.webkit.org/attachment.cgi?id=240082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240082&action=review

>>> Source/WebCore/html/RelList.cpp:63
>>> +    if (!hasRel()) {
>> 
>> Can we just check if value.isNull() is true?
> 
> I’ll go further and say that we might not need this optimization at all. And if we do need it, we might want to put it into the SpaceSplitString::set function rather than only have it here in RelList.

I think this would require updating SpaceSplitString, because there is currently the following assertion in SpaceSplitStringData::create(const AtomicString& keyString):
ASSERT(!keyString.isNull());

which is called from SpaceSplitString::set().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141020/d2233080/attachment-0002.html>


More information about the webkit-unassigned mailing list