[Webkit-unassigned] [Bug 137860] Add relList to the anchor, area and link elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137860

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 240082
  --> https://bugs.webkit.org/attachment.cgi?id=240082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240082&action=review

That's a lot of testing, Benjamin will love it :)

> LayoutTests/fast/dom/HTMLAnchorElement/rel-list-gc.html:7
> +<script src="script-tests/rel-list-gc.js"></script>

Please embed the JS in this file instead of adding a new js file whenever possible. I know a lot of layout tests are doing this but this is the *old* style.

> LayoutTests/fast/dom/HTMLAnchorElement/rel-list.html:7
> +<script src="script-tests/rel-list.js"></script>

Please embed the JS in this file.

> LayoutTests/fast/dom/HTMLAnchorElement/script-tests/rel-list-gc.js:3
> +function gc()

I am pretty sure js-test-pre.js already has a gc() function?

> LayoutTests/fast/dom/HTMLAnchorElement/script-tests/rel-list.js:136
> +function shouldThrowDOMException(f, ec)

We already have shouldThrow() in js-test-pre.js for all this, please use the existing test infrastructure whenever possible.

> LayoutTests/fast/dom/HTMLAreaElement/rel-list-gc.html:7
> +<script src="script-tests/rel-list-gc.js"></script>

embed js here

> LayoutTests/fast/dom/HTMLAreaElement/rel-list.html:7
> +<script src="script-tests/rel-list.js"></script>

embed js here

> LayoutTests/fast/dom/HTMLAreaElement/script-tests/rel-list-gc.js:3
> +function gc()

Reuse function in js-test-pre.js

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141019/3264540d/attachment-0002.html>