[Webkit-unassigned] [Bug 137793] Calling glReadPixels with BGRA format on an NVIDIA machine with an opaque context returns the wrong alpha values.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137793

--- Comment #15 from Tim Horton <thorton at apple.com> ---
Comment on attachment 240053
  --> https://bugs.webkit.org/attachment.cgi?id=240053
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240053&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:72
> +    // NVIDIA drivers have a bug where calling readPixels in BGRA can return the wrong values for the alpha channel when the alpha is off for the context.

Is this true for all NVIDIA drivers, historically? Is this likely to change? Should we be detecting the wrongness somehow instead of just flipping things around like this?

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:78
> +        src.rowBytes = width*4;

Spaces around the star, please.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:84
> +        dest.rowBytes = width*4;

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141018/430fc67a/attachment-0002.html>