[Webkit-unassigned] [Bug 137797] ResourceRequest deserialization unnecessarily calls partitionName() on encoded cache partition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137797

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
(In reply to comment #2)
> Not exactly a regression. The deserialization of the cache partition was
> added in <http://trac.webkit.org/changeset/146544>, after that commit.

Right, sorry about that. I did not look much further, just saw that the patch made the argument processing mandatory by moving it from the callers to the method implementation.

> 
> I'm a little leery of adding an argument to setCachePartition, but it
> doesn't look like there's much way around that. Also, isn't there a better
> place in the class to place the enum definition than between two function
> definitions?

I see 3 possibilities:
1. Add an enum / bool argument as I did
2. Add a new setter without the argument processing. I initially wanted to do this but did not know how to call it.
3. Move the partitionName() to calls sites but I assumed we did not want to do that since it was this way and we changed it.

I am honestly OK with 1 or 2 if someone has a good name for the new setter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/2790a47e/attachment-0002.html>