[Webkit-unassigned] [Bug 137345] [WinCairo] Accelerated compositing is not implemented.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137345

--- Comment #12 from peavo at outlook.com ---
(In reply to comment #9)
> Comment on attachment 240010 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240010&action=review
> 

Thanks for reviewing!

> Really nice work! Are you able to activate any o the 3D CSS effects with
> this turned on?
> 

Yes, I believe so.
For example, http://www.w3.org/Talks/2012/0416-CSS-WWW2012/Demos/transitions/demo-transitions-3-shadows.html seems to be working now :)

> > Source/WebKit/win/WebView.cpp:6802
> >      if (m_backingLayer)
> 
> Whoops (on us!)! This m_backingLayer test is not necessary (see line
> 6755/6794 above).
> 

This is actually needed, as the previous call might take us out of compositing mode, and set m_backingLayer to null.

> > Source/WebKit/win/WebCoreSupport/AcceleratedCompositingContext.cpp:2
> > + * Copyright (C) 2014 Apple, Inc.
> 
> Shouldn't this be copyright you? If you based it off an Apple copyrighted
> file, just put both names.
> 

If this is not too important, I left it as is; I wouldn't mind :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/6b04aed0/attachment-0002.html>