[Webkit-unassigned] [Bug 137822] [GTK] Improve zooming gesture positioning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137822

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240016|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 240016
  --> https://bugs.webkit.org/attachment.cgi?id=240016
Patch to improve zooming gesture look&feel

View in context: https://bugs.webkit.org/attachment.cgi?id=240016&action=review

This makes the zoom gesture work as expected, thanks!

> Source/WebKit2/UIProcess/WebPageProxy.h:470
> +
> +    void getCenterForZoomGesture(const WebCore::IntPoint& centerInViewCoordinates, WebCore::IntPoint& center);
>  #endif

I would use a separate block since this is for text composition stuff.

> Source/WebKit2/UIProcess/gtk/GestureController.cpp:33
> +#include "WebPageMessages.h"

You shouldn't need this.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:581
> +
> +    void getCenterForZoomGesture(const WebCore::IntPoint& centerInViewCoordinates, WebCore::IntPoint& result);
>  #endif

Same here.

> Source/WebKit2/WebProcess/WebPage/WebPage.messages.in:313
> +
> +    GetCenterForZoomGesture(WebCore::IntPoint centerInViewCoordinates) -> (WebCore::IntPoint center)
>  #endif

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/30eea2fd/attachment-0002.html>