[Webkit-unassigned] [Bug 137735] [GTK] Move touch events handling from Platform to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137735

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239857|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 239857
  --> https://bugs.webkit.org/attachment.cgi?id=239857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239857&action=review

Another file nuked yay!

Everything seems to be right, it's a r+ for me, but consider my suggestions before landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:806
> +static void webkitWebViewBaseGetTouchPointForEvent(WebKitWebViewBase* webViewBase, GdkEvent* event, Vector<WebPlatformTouchPoint>& touchPoints)

Nit: GetTouchPoints

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:811
> +    for (auto it = priv->touchEvents.begin(); it != priv->touchEvents.end(); ++it) {

You can use a modern for loop here.

for (auto& touchEvent : priv->touchEvents)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:828
> +    }

I am not sure a lambda is appropriate here, for me it seems far more confusing than calling a function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/0a60038b/attachment-0002.html>