[Webkit-unassigned] [Bug 137782] [GLIB] Add API to GMainLoopSource to schedule sources after a delay in microseconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137782

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 239954
  --> https://bugs.webkit.org/attachment.cgi?id=239954
Re-submitted for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=239954&action=review

>> Source/WTF/wtf/gobject/GMainLoopSource.cpp:295
>> +    };
> 
> Either one of these two is wrong, check the position of WTF::move and the one of the callback.

I don't understand what you mean. There are two WTF::move here one is for the destroy func and the other is for the bool callback. There's nothing wrong there.

>> Source/WTF/wtf/gobject/GMainLoopSource.cpp:338
>> +
> 
> Since the only difference is the callback function, couldn't we use a template and avoid repetitions?

I guess, I find this more convenient to use, but in any case, that would be a different issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141017/fdc9e7cc/attachment-0002.html>