[Webkit-unassigned] [Bug 137793] Don't use BGRA format when reading rendering results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137793

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239980|review?                     |review-
              Flags|                            |

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 239980
  --> https://bugs.webkit.org/attachment.cgi?id=239980
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239980&action=review

I think this change will break whatever port uses the OpenGLES backend (EFL maybe?).

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:254
> +    ::glReadPixels(0, 0, m_currentWidth, m_currentHeight, GL_RGBA, GL_UNSIGNED_BYTE, pixels);

I think this was here to support OpenGLES clients. See GraphicsContext3DOPenGLES.cpp, which looks like GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary, except that it swaps the R and B pixels.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141016/60a3aa38/attachment-0002.html>