[Webkit-unassigned] [Bug 137553] abandoned select option is reselected when shift selecting new options

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137553

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239868|1                           |0
        is obsolete|                            |

--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 239868
  --> https://bugs.webkit.org/attachment.cgi?id=239868
Ready for review

View in context: https://bugs.webkit.org/attachment.cgi?id=239868&action=review

>>> LayoutTests/fast/forms/listbox-selection-after-typeahead.html:10
>>> +description('<p>Test for <i>'
>> 
>> No need to specify the bug URL here.
> 
> I would stick with the bug URL + Title as explained here: http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree#Understandableclear

I don't think that wiki is up to date... it still recommends using testRunner's waitUntilDone() and notifyDone().

>>> LayoutTests/fast/forms/listbox-selection-after-typeahead.html:55
>>> +    for (var i = 0; i < select.options.length; i++)
>> 
>> ++i
> 
> Is it just a coding style? Would it make any in difference as per complex C++ iterators?

Yes, coding style in both JS and C++. No performance difference for builtin types.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141016/038897ec/attachment-0002.html>