[Webkit-unassigned] [Bug 137776] Allow reuse of BitmapTextureImageBuffer instances

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 16 13:31:32 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=137776

--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 239945
  --> https://bugs.webkit.org/attachment.cgi?id=239945
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239945&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperImageBuffer.h:36
> +    bool canReuseWith(const IntSize& /* contentsSize */, Flags = 0) { return true; }

Isn't this function virtual? if so, please mark it explicitly as virtual. You will also want to use override (and likely final).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141016/dc7e95fb/attachment-0002.html>


More information about the webkit-unassigned mailing list