[Webkit-unassigned] [Bug 137685] [GTK] Move click counter logic back to WebKitWebViewBase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137685





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-10-14 23:23:23 PST ---
(In reply to comment #4)
> Again, I think we should just move this class to WebKit2. It's useful to separate code into classes.

I don't think it's always helpful, in this case we end up with a very small class (another file to build) with a single method that IMO belongs to the view. In the case of the DND helper is even worse, because having half of the code in the web view and the other half in a separate class makes quite difficult to follow the code (and DND logic is already complex enough). It made sense to me when we needed to share the common code, but that's no longer needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.