[Webkit-unassigned] [Bug 136938] XMLHttpRequest should have a responseURL attribute (added in recent XHR specification drafts)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136938


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239793|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #29 from Alexey Proskuryakov <ap at webkit.org>  2014-10-14 22:36:30 PST ---
(From update of attachment 239793)
View in context: https://bugs.webkit.org/attachment.cgi?id=239793&action=review

r- for the fragment issue.

I also looked over test syntax and output but didn't deeply think about test semantics yet.

> LayoutTests/http/tests/xmlhttprequest/basic-auth-expected.txt:4
> +TEST COMPLETE
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async"

The test should only say "TEST COMPLETE" once it's actually complete.

To achieve this, you should switch from waitUntilDone/notifyDone to jsTestIsAsync=true/finishJSTest().

> LayoutTests/http/tests/xmlhttprequest/basic-auth-expected.txt:10
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async2"
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async3"
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async4"
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async5"
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async6"
> +PASS req.responseURL is "http://127.0.0.1:8000/xmlhttprequest/resources/basic-auth/basic-auth.php?uid=async7"

This output is out of order. The test should use a single mechanism for output to avoid that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.