[Webkit-unassigned] [Bug 137597] Support activation behavior of link element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137597





--- Comment #9 from Chris Dumez <cdumez at apple.com>  2014-10-11 21:38:40 PST ---
(From update of attachment 239696)
View in context: https://bugs.webkit.org/attachment.cgi?id=239696&action=review

> Source/WebCore/html/HTMLLinkElement.cpp:402
> +    if (MouseEvent::canTriggerActivationBehavior(*event)) {

nit: We should probably add an ASSERT(event); at the beginning of this function.

> LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click-expected.txt:6
> +FAIL event.data should be 'test:ok'. Was test:ok.

uh oh..

> LayoutTests/fast/dom/html-link-element-activation-behavior-on-element-click.html:15
> +  shouldBeEqualToString("event.data", "'test:ok'")

Remove the single quotes around test:ok

> LayoutTests/fast/dom/html-link-element-activation-behavior-on-mouse-click.html:15
> +  shouldBe("event.data", "'test:ok'")

shouldBeEqualToString()

> LayoutTests/fast/dom/html-link-element-activation-behavior-url-is-null.html:15
> +shouldBe("target.dispatchEvent(mouseEvent)", "true");

shouldBeTrue()

> LayoutTests/fast/dom/resources/html-link-element-activation-behavior-target.html:4
> +  window.parent.postMessage("test:ok", "*");

nit: I think we use 4-space indentation in our JS usually.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.