[Webkit-unassigned] [Bug 15256] Impossible to place an editable selection inside empty elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 19:19:41 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=15256


David Gatwood <dgatwood at mac.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #239657|0                           |1
        is obsolete|                            |




--- Comment #50 from David Gatwood <dgatwood at mac.com>  2014-10-10 19:19:33 PST ---
Created an attachment (id=239665)
 --> (https://bugs.webkit.org/attachment.cgi?id=239665&action=review)
Rework of patch to prevent deletion of empty element

Turns out that previous patch caused failures later, for two reasons:

1.  In some cases, the editing code was inserting a placeholder <br> tag to avoid the element becoming empty, but that isn't needed or desirable if the editing boundaries are already distinct.
2.  Deleting that <br> tag caused a crash because the merge code wasn't expecting to ever encounter a situation where such a node still existed, and tried to merge it with its parent.

This fix corrects those additional bugs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list