[Webkit-unassigned] [Bug 137615] REGRESSION(r174535): Updated expectations for the layout tests have wrong color (or wrong message)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137615





--- Comment #3 from Benjamin Poulain <benjamin at webkit.org>  2014-10-10 11:29:42 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > It is intended. The commit r174535 intentionally breaks all support of :not(:link) and :not(:visited).
> > 
> > Eventually we should fix the regression, but in the short term, the benefits outweigh the risks.
> > 
> > Help is welcome if you have time :)
> 
> Shouldn't then be a better idea to mark the test as failing?
> 
> Or at least update the text saying something like:
> 
> "This anchor should have a red background until bug #XXXX is fixed. Once that is done, this anchor should have a green background."
> 
> ???
> 
> Otherwise is very confusing and misleading.

Checking in failing test is a common practice. The reason is those test can still catch unintended changes. If we were to mark them as failing, an intended change would be ignored by the bots.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.