[Webkit-unassigned] [Bug 137586] import-w3c-test rewrites relative src paths in ref files incorrectly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137586





--- Comment #2 from Bem Jones-Bey <bjonesbe at adobe.com>  2014-10-10 10:51:48 PST ---
(From update of attachment 239587)
View in context: https://bugs.webkit.org/attachment.cgi?id=239587&action=review

> Tools/ChangeLog:7
> +        This patch fixes a bug in test_converter.py where src paths weren't
> +        getting rewritten properly. It also adds some tests for this case.

i think you need to write a better description, it looks like this patch not only fixes src path rewriting, but also adds support for rewriting source paths in style elements.

> Tools/Scripts/webkitpy/w3c/test_converter.py:46
> +

Nit: This newline is just noise in the diff.

> Tools/Scripts/webkitpy/w3c/test_converter.py:154
> +        return self.convert_reference_relpaths(converted[1])
> +

it looks like you accidentally duplicated this return statement?

> Tools/Scripts/webkitpy/w3c/test_converter.py:175
> -                    converted = self.convert_reference_relpaths(attr_value)
> +                    converted = re.sub(attr_value, self.convert_reference_relpaths(attr_value), converted)

I don't think I understand how this fixed the issue. Can you explain?

> Tools/Scripts/webkitpy/w3c/test_importer.py:279
> +

Nit: This looks line another stray line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.