[Webkit-unassigned] [Bug 136818] [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136818





--- Comment #23 from chris fleizach <cfleizach at apple.com>  2014-10-10 08:48:36 PST ---
(From update of attachment 239620)
View in context: https://bugs.webkit.org/attachment.cgi?id=239620&action=review

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:138
> +    for (Node* parentNode = node(); parentNode; parentNode = parentNode->parentNode()) {

this patch looks good. I think after Darin's comments in another bug we should change this for loop to

 for (const auto& ancestor : ancestorsOfType<Node>(node()))

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:160
> +    for (Node* parentNode = node(); parentNode; parentNode = parentNode->parentNode()) {

ditto
 for (const auto& ancestor : ancestorsOfType<Node>(node()))

> Source/WebCore/accessibility/AccessibilityTableCell.h:49
> +    bool isRowHeaderCell();

these two methods should be const

bool isRowHeaderCell() const;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.