[Webkit-unassigned] [Bug 137485] [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137485





--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-10-10 02:11:37 PST ---
(From update of attachment 239411)
View in context: https://bugs.webkit.org/attachment.cgi?id=239411&action=review

>>> Source/WTF/wtf/gobject/GMutexLocker.h:78
>>> +            return;
>> 
>> Hmm this makes the template useless, because the recursive mutexes will act as normal ones, won't they?
> 
> Hmm this makes the template useless, because the recursive mutexes will act as normal ones, won't they?

The idea is that the same GMutexLocker object shouldn't lock a mutex already locked, but two different GMutexLocker objects, wrapping the same GRecMutex should be allowed. Which is the case I'm covering here, schedule calls cancel, both locking the mutex, but using different GMutexLocker objects.

>>> Source/WTF/wtf/gobject/GThreadSafeMainLoopSource.h:33
>>> +typedef struct _GRecMutex GRecMutex;
>> 
>> What do we need this for?
> 
> What do we need this for?

It's the forward declaration of GRecMutex, needed by the m_mutex memeber that is a GRecMutex, to avoid including glib.h in the header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.