[Webkit-unassigned] [Bug 137330] RenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing the window

Thu Oct 9 21:13:37 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=137330

--- Comment #51 from Said Abou-Hallawa <sabouhallawa at apple.com>  2014-10-09 21:13:30 PST ---
(In reply to comment #49)
> (From update of attachment 239593 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239593&action=review
> 
> > LayoutTests/mathml/opentype/munderover-window-resize-expected.html:1
> > +<!DOCTYPE html>
> 
> The filename should be changed; this isn't about resize any more, it's about layout being unstable for some mathml operators.
> 

Done, I renamed it to be munderover-layout-resize since it is still about resizing the container of the math and making sure the layout of the munderover math object is still valid.

> > LayoutTests/mathml/opentype/munderover-window-resize-expected.html:4
> > +  <title>Open Type MATH - under-over operator</title>
> 
> We usually don't bother with titles in tests.
> 

Removed.  I copied it from LayoutTests\mathml\opentype\opentype-stretchy-horizontal.html.

> > LayoutTests/mathml/opentype/munderover-window-resize-expected.html:5
> > +  <meta charset="utf-8">
> 
> You don't need this.
>

Removed.  I copied it from LayoutTests\mathml\opentype\opentype-stretchy-horizontal.html.

> > LayoutTests/mathml/opentype/munderover-window-resize-expected.html:7
> > +    /* This font is taken from Mozilla's test suite. */
> 
> Is the comment necessary?
> 

Removed.  I copied it from LayoutTests\mathml\opentype\opentype-stretchy-horizontal.html.

> > LayoutTests/mathml/opentype/munderover-window-resize.html:41
> > +      setTimeout(function(){testRunner.notifyDone();},7000);
> 
> We can't have a test take 7s. Imagine if every test took multiple seconds; we have tens of thousands of them!
> 
> You should change this test to do a single layout (foo.style.width = "400px") which presumably would also show the bug. You can probably do this synchronously:
> 
> <div id="container" style="width: 300px">....
> 
> <script>
> document.body.offsetWidth; // force initial layout
> document.getElementById('container').style.width = "400px";
> </script>

I tried your solution but I did not notice any overlap in the released WebKit (the one without my change) when opening the test file.  Or at least my eye could not catch any change so I was not sure if the layout was forced before the resizing or not.  I kept the CSS animation but I shortened its period to be 1 second only.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.